Re: [Qemu-devel] [PATCH 0/3] target-ppc: Add support for dumping guest memory using qemu gdb server

[Aneesh Kumar K.V]

Andreas Färber <afaer...@suse.de> writes:

> Hi Aneesh,
>
> Am 19.08.2013 14:29, schrieb Aneesh Kumar K.V:
>> This patch series implement support for dumping guest memory using qemu gdb 
>> server.
>
> I had a quick look through but will leave in-depth review to Alex or
> Anthony.
>
> Do you plan to implement dumping guest memory via QMP, too?

Are you looking at memsave command ? That would fail before. This patch
series should fix that too. For memsave to fail we need the below patch

diff --git a/cpus.c b/cpus.c
index 0f65e76..3340150 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1309,7 +1309,10 @@ void qmp_memsave(int64_t addr, int64_t size, const char 
*filename,
         l = sizeof(buf);
         if (l > size)
             l = size;
-        cpu_memory_rw_debug(cpu, addr, buf, l, 0);
+        if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) != 0) {
+            error_set(errp, QERR_IO_ERROR);
+            goto exit;
+        }
         if (fwrite(buf, 1, l, f) != l) {
             error_set(errp, QERR_IO_ERROR);
             goto exit;