On 19.08.2013, at 13:04, Anton Blanchard wrote:
>
> Hi Anthony,
>
>>> + if (resource == 4) {
>>
>> This ought to be a #define. There's no else here, is that expected?
>> Should you return failure for a different resource?
>
> Good point, I made it a define. We were returning H_P2 for a different
> resource, but it was a bit of a twisted maze of return statements. I
> tried to clear it up in this version.
>
>> Without knowing this interface better, a few things come to mind.
>>
>> Is mflags a boolean? If so, you can reduce this to a single loop and
>> drop the switch() statement. If mflags is truly a set of flags, it
>> would be nice to use #define to give the flags a proper symbolic name.
>
> Unfortunately it isn't a boolean, but yes it should have be made
> clearer with a #define.
>
> Anton
> --
>
> pseries: Add H_SET_MODE hcall to change guest exception endianness
>
> H_SET_MODE is used for controlling various partition settings. One
> of these settings is the endianness a guest takes its exceptions in.
>
> Signed-off-by: Anton Blanchard <an...@samba.org>
Thanks, applied after I replaced tabs with spaces ;).
Alex
