On 09/20/2013 09:12 AM, Kevin Wolf wrote: > Am 20.09.2013 um 17:03 hat Eric Blake geschrieben: >> On 09/20/2013 05:54 AM, Kevin Wolf wrote: >>> BlockDriverStates shouldn't be affected by an unplugged guest device, >>> except if created with the legacy -drive command line option or the >>> drive_add HMP command. >>> >>> Make the automatic deletion as well as cancelling of jobs conditional on >>> an enable_auto_del boolean that is only set in drive_init(). >>> >>> Signed-off-by: Kevin Wolf <kw...@redhat.com> >>> --- >> >>> +++ b/include/sysemu/blockdev.h >>> @@ -37,6 +37,7 @@ struct DriveInfo { >>> int bus; >>> int unit; >>> int auto_del; /* see blockdev_mark_auto_del() */ >>> + bool enable_auto_del; /* Only for legacy drive_init() */ >> >> auto_del is 0-initialized, and only ever assigned to 1. Should it also >> be bool? > > Probably. A lot of qemu code uses int for boolean values. I'm trying to > get rid of them in the block layer in the long run, but so far I haven't > aggressively converted fields that I don't touch otherwise.
At any rate, that's an independent question; I forgot to mention: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature