On Mon, Oct 14, 2013 at 10:18 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Fri, Oct 11, 2013 at 10:59:40AM +0800, liu ping fan wrote: >> On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >> > On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: >> >> Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: >> >> >> > Are you sure? This is not done for any other compat property. >> >> >> > >> >> >> > Paolo >> >> > It's done if we use the property from C. >> >> > See PCI_HOST_PROP_PCI_HOLE64_SIZE. >> >> > >> >> > You want compiler to catch errors, that's >> >> > much better than a runtime failure. >> >> >> >> I agree, but I think there should be no need to use the property from C. >> >> >> >> Paolo >> > >> > Well this patchset does use it from C. >> > If it's done it needs a macro. >> >> hpet.h is the ideal place to put the macro, so pc.c can see it. But >> what about PC_COMPAT_1_7 in pc.h? I think it is not right to include >> hpet.h. > > Why not? > Since pc.h is included by so many hpet unrelated drivers, if pc.h include hpet.h, then we will export the internal of hpet struct.
Regards, Ping Fan
