Am 21.10.2013 um 22:41 hat Eric Blake geschrieben: > On 10/21/2013 03:16 AM, Wenchao Xia wrote: > > The define will be moved to qapi-schema.json later, so rename the > > prefix to match its naming style. > > Wouldn't it be simpler to fix the code generator to special case QEvent > to turn into QEVENT, instead of having to go through this churn? But if > we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical:
Or rather, instead of special casing QEvent, it shouldn't insert underscores if there is nothing between the two capital letters. I've had a similar case with AIO in the blockdev-add series; and while renaming it to Aio worked, this kind of thing doesn't seem to be a rare exception in practice, so it might be worth adjusting the generator. Kevin
pgpqDip3zyYXX.pgp
Description: PGP signature
