On Wednesday 09 December 2009, Michael S. Tsirkin wrote: > On Wed, Dec 09, 2009 at 03:49:04PM +0100, Arnd Bergmann wrote: > > > > - TFR(fd = open("/dev/net/tun", O_RDWR)); > > + if (!*dev) > > + dev = "/dev/net/tun"; > > + > > Did you test without dev parameter? I think dev will be NULL > so this will deference a nullpointer ... > probably if (!dev) is what you mean?
D'oh. will fix. > will be neater if you put [,dev=str] after [,script=file] > Also - it does need a string, but only insofar as all options are strings. > Maybe dev=devfile or dev=file would be clearer. Yep. Thanks, Arnd