On Wed, Dec 11, 2013 at 09:22:13PM +1100, Alexey Kardashevskiy wrote: > With the great help from Paolo, I am presenting yet another try of bootindex > support on sPAPR, this time with some QOM fixes. Details are in the commit > messages. > Please, comment. Thanks. > > Alexey Kardashevskiy (5): > boot: extend get_boot_devices_list() to ignore suffixes > spapr-llan: add to boot device list > spapr-vio: fix firmware names > qdev: introduce FWPathProvider interface > spapr: define interface to fix device pathname > > Hervé Poussineau (1): > qom: detect bad reentrance during object_class_foreach > > Paolo Bonzini (2): > qom: do not register interface "types" in the type table > vl: allow customizing the class of /machine
Looks good overall. But this seems to suffer from the same problem as existing bootindex code on x86: you can't add a bootable device by hotplug. And we really want to fix it on x86 too. This might be fixable using FW CFG read callback, and updating the bootindex blob dynamically. See how e.g. acpi_build_update works. > hw/core/Makefile.objs | 1 + > hw/core/fw-path-provider.c | 34 ++++++++++++++++++ > hw/core/qdev.c | 18 +++++++++- > hw/net/spapr_llan.c | 3 ++ > hw/nvram/fw_cfg.c | 2 +- > hw/ppc/spapr.c | 80 > ++++++++++++++++++++++++++++++++++++++++++- > hw/ppc/spapr_vio.c | 2 ++ > include/hw/boards.h | 1 + > include/hw/fw-path-provider.h | 31 +++++++++++++++++ > include/sysemu/sysemu.h | 2 +- > qom/object.c | 17 +++++++-- > tests/Makefile | 1 + > vl.c | 11 ++++-- > 13 files changed, 193 insertions(+), 10 deletions(-) > create mode 100644 hw/core/fw-path-provider.c > create mode 100644 include/hw/fw-path-provider.h > > -- > 1.8.4.rc4 >
