On 3 January 2014 16:15, Peter Crosthwaite <peter.crosthwa...@xilinx.com> wrote: > One subtle question before respinning - should the > qdev_set_nic_properties actually be conditional? Setting it to an > unused NIC should be harmless, so perhaps it should be outside the > if(nd->used). Other boards/MAC combos that dont do the > qdev_check_nic_model can then just dispose of the if (nd->used) check > altogether.
Well qdev_set_nic_properties as it stands today will unconditionally assume you've passed it a valid NICInfo, so we have to a void calling it if nd->used isn't set. If you're asking whether that nd->used check should be moved into qdev_set_nic_properties, I'm not sure : I don't have a good enough grasp of how the net code works and how it ought to work for embedded always-instantiated NICs to be able to say. thanks -- PMM
