Hi, Am 28.01.2014 01:48, schrieb Peter Crosthwaite: > On Tue, Jan 28, 2014 at 3:52 AM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Is there anything really ARM-specific in this reset_gpio >> function, or could it be implemented at a common level for >> all target architectures? >> > > Not yet, but probably will be ARM specific once I add the cpu reset > pin state. Unless Andreas is happy for that pin state and all this > code to go up to the base TYPE_CPU class. > > I wonder however, whether different arch will have level/edge/high/low > variances in reset behavior that must be accommodated. > > Andreas, you want this in CPU or should we leave it here in ARM land?
I'm currently swimming in work, so haven't really reviewed this yet... If you have a good solution that requires additions to common CPU state then so be it. However, keep in mind that for x86 at least we need to remain migration-compatible, so state additions would need to go into an optional VMState subsection for backwards compatibility. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
