On Wed, 05 Mar 2014 13:33:43 -0700 Eric Blake <ebl...@redhat.com> wrote:
> On 03/05/2014 09:10 AM, Igor Mammedov wrote: > > Adds option to -m > > "size" - startup memory amount > > > > For compatibility with legacy CLI if suffix-less number is passed, > > it assumes amount in Mb. > > > > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > --- > > v2: > > - suggested by Andreas Färber <afaer...@suse.de> > > * s/fprintf/error_report/ > > * rename 'mem' option to 'size' > > - fix conflict with missing numa QemuOpts > > Given the amount of rework in v2, it may have been smarter to drop my > R-b tag. But beyond Andreas' findings of missing s/mem/size/ instances, > I'm not spotting any problems, so if that's the only fix you make for > v4, you can keep my R-b. > Thanks!
