Am 05.03.2014 18:30, schrieb Marcel Apfelbaum: > +struct MachineState { > + /*< private >*/ > + Object parent_obj; > + /*< public >*/ > + > + char *accel; > + bool kernel_irqchip; > + int kvm_shadow_mem; > + char *kernel; > + char *initrd; > + char *append; > + char *dtb; > + char *dumpdtb; > + int phandle_start; > + char *dt_compatible; > + bool dump_guest_core; > + bool mem_merge; > + bool usb; > + char *firmware; > + > + QEMUMachineInitArgs init_args; > +};
If I'm reading directly, init_args is the only field used in this 3-patch series. Should we drop the unused ones for now? Or do you think we should get the whole conversion done for 2.0 and therefore keep them? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg