On 2014-03-12 17:58, Andreas Färber wrote: > Am 26.07.2013 20:26, schrieb Jan Kiszka: >> With this patch QEMU handles qAttached request from gdb. When QEMU > > "With this patch" is always weird to read in Git history, also a > "gdbstub: " prefix would've been nice for consistency.
Yes, will rephrase this. > >> replies 1, GDB sends a "detach" command at the end of a debugging >> session otherwise GDB sends "kill". >> >> The default value for qAttached is 1 on system emulation and 0 on user >> emulation. >> >> Based on original version by Fabien Chouteau. > > If this is based on code by Fabien, shouldn't it carry his Signed-off-by > before yours? Need to check how similar our versions actually are, if I can reuse his signed-off or if I changed it (in that case it's not appropriate to keep the original signed-off - according to my understanding). > > Since "GDB stub" is in "Odd Fixes" state, maybe just step up as > maintainer and send a pull like for SLIRP? :) Oh, I can surely send a pull, but I can't handle another maintainership properly. Slirp already became a stepchild... Thanks for looking into this. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux
