On Thu, Apr 10, 2014 at 09:27:44PM +0300, Marcel Apfelbaum wrote: > v4 -> v5 > - Addressed Michael S. Tsirkin's comments (patch 2/2): > - Open-coded pci_config_is_reserved() method. > > v3 -> v4: > - Addressed Kevin O'Connor's comments: > - Refactored a for loop in patch 1/2. > - Addressed Michael S. Tsirkin's comments (patch 2/2): > - Removed not needed method > - Test only base registers (dropped limits tests) > - Renamed a helper method > - Used 0xFF to test if the memory is reserved > - Simplified code in pci_bridge_has_region > - I did keep the code that restores base's address as I don't want > to modify the registers in a 'query' method. (as replied on the mail > thread) > > v2 -> v3: > - Addressed Michael S. Tsirkin's comments: > - I/O and Prefetchable Memory are optional. Do not allocate ranges > if they are not implemented (2/2). > - Note that 2/2 patch can be seen as a separate fix. However, it > is related to ranges reservation. > > v1 -> v2: > - Thanks Gerd Hoffmann for the review. > - Addressed Michael S. Tsirkin's comments: > - Limit capabilities query to 256 iterations, to make sure we > don't get into an infinite loop with a broken device. > > > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. > > Marcel Apfelbaum (2): > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices > attached > hw/pci: check if pci2pci bridges implement optional limit registers > > src/fw/pciinit.c | 12 +++++------- > src/hw/pci.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ > src/hw/pci.h | 10 ++++++++++ > 3 files changed, 60 insertions(+), 7 deletions(-)
It would be nice to have a seabios release with these patches included in QEMU: make it easier for people to use hotplug. Gerd? > -- > 1.8.3.1
