On 01/13/2010 11:54 AM, Amit Shah wrote:
clang-analyzer points out a redundant assignment.Signed-off-by: Amit Shah<amit.s...@redhat.com> --- block/qcow2-refcount.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 54b19f8..3a2d44a 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -511,7 +511,6 @@ int qcow2_update_snapshot_refcount(BlockDriverState *bs, l2_table = NULL; l1_table = NULL; l1_size2 = l1_size * sizeof(uint64_t); - l1_allocated = 0; if (l1_table_offset != s->l1_table_offset) { if (l1_size2 != 0) { l1_table = qemu_mallocz(align_offset(l1_size2, 512));
I'd remove the l1_allocated = 0 assignment in the else branch instead (the idea is, assign l1_allocated = 1 right after any qemu_malloc.
Paolo
