Re: [Qemu-devel] [PATCH 1/6] vl.c: Remove dead assignment

[Anthony Liguori]

On 01/13/2010 04:54 AM, Amit Shah wrote:

clang-analyzer pointed out the value of 'sockets' is never reused.

Signed-off-by: Amit Shah<amit.s...@redhat.com>
CC: Andre Przywara<andre.przyw...@amd.com>

Applied.  Thanks.

Regards,

Anthony Liguori

---
  vl.c |    6 +-----
  1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/vl.c b/vl.c
index b048e89..e49e7bd 100644
--- a/vl.c
+++ b/vl.c
@@ -2613,17 +2613,13 @@ static void smp_parse(const char *optarg)
          threads = threads>  0 ? threads : 1;
          if (smp == 0) {
              smp = cores * threads * sockets;
-        } else {
-            sockets = smp / (cores * threads);
          }
      } else {
          if (cores == 0) {
              threads = threads>  0 ? threads : 1;
              cores = smp / (sockets * threads);
          } else {
-            if (sockets == 0) {
-                sockets = smp / (cores * threads);
-            } else {
+            if (sockets) {
                  threads = smp / (cores * sockets);
              }
          }