On 05/30/2014 03:59 PM, Marcelo Tosatti wrote: Your subject line is harder than necessary. 'git am' would put the "(v2)" suffix into qemu.git (it only strips the [...] prefix). The proper way to generate a v2 is with 'git send-email -v2', which produces [PATCH v2] as the subject line prefix.
>
> v2: - fix changelog to mention "machine" not "machines
> - remove TARGET_I386 ifdef
>
> -------------
This information is useful to reviewers, but not to qemu.git. As such,
it belongs...
>
>
> Add a link to rtc under /machine providing a stable
> location for management apps to query "date" field.
>
> {"execute":"qom-get","arguments":{"path":"/machine/rtc","property":"date"}}
>
> Suggested by Paolo Bonzini.
>
> Signed-off-by: Marcelo Tosatti <mtosa...@redhat.com>
...
here, after a --- separator. Again, using 'git send-email' will
automatically format a --- separator into your mail. It appears that
you free-formed your patch; while it is not necessarily an automatic
rejection, it does make life harder for the maintainers, and may slow
down the inclusion of your patches. There is a real benefit to using a
workflow that makes the maintainer's life easier. :)
Also, we generally prefer that when sending a v2 patch (or patch series)
that it be sent as a new top-level thread rather than buried In-Reply-To
an existing thread; not everyone looks in deeply nested threads for new
patches.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
