On Mon, Jun 09, 2014 at 08:36:17PM -0600, Eric Blake wrote:
> On 06/09/2014 08:29 PM, Hu Tao wrote:
> > On Mon, Jun 09, 2014 at 05:02:51PM -0600, Eric Blake wrote:
> >> On 06/09/2014 04:25 AM, Hu Tao wrote:
> >>> From: Wanlong Gao <gaowanl...@cn.fujitsu.com>
> >>>
> >>> If the total number of the assigned numa nodes memory is not
> >>> equal to the assigned ram size, it will write the wrong data
> >>> to ACPI table, then the guest will ignore the wrong ACPI table
> >>> and recognize all memory to one node. It's buggy, we should
> >>> check it to ensure that we write the right data to ACPI table.
> >>>
> >>> Signed-off-by: Wanlong Gao <gaowanl...@cn.fujitsu.com>
> >>> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com>
> >>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> >>> Signed-off-by: Hu Tao <hu...@cn.fujitsu.com>
> >>> ---
> >>> numa.c | 14 ++++++++++++++
> >>> 1 file changed, 14 insertions(+)
> >>>
> >>
> >>> + if (numa_total != ram_size) {
> >>> + error_report("qemu: total memory size for NUMA nodes (%"
> >>> PRIu64 ")"
> >>> + " should equal to RAM size (" RAM_ADDR_FMT
> >>> ")\n",
> >>
> >> error_report() should not include trailing \n
> >
> > Thanks.
>
> Sorry for not noticing earlier, but a couple more things to fix:
>
> error_report already prefixes the error message, so s/qemu: //
>
> The grammar is a bit awkward; how about:
>
> "total memory for NUMA nodes (%" PRIu64 ") should equal RAM size ("
> RAM_ADDR_FMT ")"
MST's already said equal RAM size. I looked up in a dictionary and found
a `equal to' example. But I was still wrong that `euqal to' is adj.
form, if it is used as verb there is no following `to'. Thanks.
Hu
