On Thu, 26 Jun 2014 15:14:01 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 26/06/2014 15:11, Eric Blake ha scritto: > >> > > >> > Can we just revert to the pre-conversion qmp-events.txt file? This is > >> > similar to the situation with qmp-commands.hx. > > As in, carrying redundant information between two files? True that it's > > no worse than qmp-commands.hx; it would also ensure we aren't regressing > > on quality of user documentation in relation to prior releases. We > > could do the restore of that file, but if we do, we should fix the bugs > > in pre-conversion qmp-events.txt (a couple events were undocumented, > > there were some grammar errors, all fixed as part of the conversion), as > > well as document events that have been added post-conversion. > > No events were added post-conversion, since ACPI_DEVICE_OST first went > in under the old scheme and Luiz then applied the conversion patch when > he did the rebase. > > We're really close to hard freeze and by extension the release. Do > _not_ strive for perfection. Get something that is mostly okay and is > an obvious patch. We'll then have 3 weeks to do documentation patches. The hard freeze argument is a strong one, but my understanding was that we wanted to move away from duplicated information. So reverting is a step back. Any strong objections against this patch?
