On 06/26/2014 07:01 AM, Paolo Bonzini wrote: > Il 26/06/2014 14:46, Luiz Capitulino ha scritto: >>> > >>> > Michal's hack at least ensures that we have event documentation, >>> even if >>> > the format changed compared to the 2.0 docs, and even if we don't have >>> > time to get something better in place before 2.1 goes out. So all of >>> > this conversation on ways to do better is nice, but if we don't get >>> > there quickly, I could at least live with Michal's patch in the >>> short term. >> I honestly don't know what's the best thing to do here. I can live with >> this patch too, although having some introductory comments at the top of >> the file saying what it is would be nicer. > > Can we just revert to the pre-conversion qmp-events.txt file? This is > similar to the situation with qmp-commands.hx.
As in, carrying redundant information between two files? True that it's no worse than qmp-commands.hx; it would also ensure we aren't regressing on quality of user documentation in relation to prior releases. We could do the restore of that file, but if we do, we should fix the bugs in pre-conversion qmp-events.txt (a couple events were undocumented, there were some grammar errors, all fixed as part of the conversion), as well as document events that have been added post-conversion. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
