On 26.06.2014 21:46, Eric Blake wrote:
On 06/26/2014 01:09 PM, Max Reitz wrote:
If "filename" is removed from the options QDict before entering
bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait
until it has been copied there and remove it from the options only
afterwards.
This fixes "filename" in the BDS being empty for block drivers which do
not need the filename because they have parsed it already (e.g. NBD).
Signed-off-by: Max Reitz <mre...@redhat.com>
---
block.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
How does this play with Kevin's bdrv_open cleanups?
https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg06173.html
To be honest, I hoped to get this series merged before Kevin's, because
I guessed adapting his series to this would be easier than the other way
round. ;-)
I guess there will be some conflicts but nothing unfixable (and the
concept will stay the same), as he still leaves bdrv_open_common() intact.
Max
