On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote: > On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues > <laurent.desnog...@gmail.com> wrote: > > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio <riku.voi...@iki.fi> wrote: > >> From: Juha Riihimäki <juha.riihim...@nokia.com>
> >> add an extra check in "two registers and a shift" to ensure element > >> size decoding logic cannot fail. > > I think there's a patch ordering problem that makes > > the comment and the change not agree :-) Sorry, apparently messed up while rebasing. > BTW I don't think adding the check for size is needed > here. The encoding at that point looks like this: > 3322222222221111111111 > 10987654321098765432109876543210 > 1111001_1___1______________1____ > 1111001_1__1_______________1____ > 1111001_1_1________________1____ > so it will stop for size == 0 given that bit 19 will have to > be set. Juha agrees so we'll drop this patch (or more precisely get the actual change out of the previous patch..)
