On 2014-08-14 13:15, Michael S. Tsirkin wrote: > On Mon, Aug 11, 2014 at 03:04:57PM +0800, Le Tan wrote: >> Hi, >> >> These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 >> chipset. The major job in these patches is to add support for emulating Intel >> IOMMU according to the VT-d specification, including basic responses to CSRs >> accesses, the logics of DMAR (DMA remapping) and DMA memory address >> translations. > > Thanks! > Looks very good overall, I noted some coding style issues - I didn't > bother reporting each issue in every place where it appears - reported > each issue once only, so please find and fix all instances of each > issue.
BTW, because I was in urgent need for virtual test environment for Jailhouse, I hacked interrupt remapping on top of Le's patches: http://git.kiszka.org/?p=qemu.git;a=shortlog;h=refs/heads/queues/vtd-intremap The approach likely needs further discussions and refinements but it already allows me to work on top with our hypervisor, and also Linux. You can see from the last commit that Le's work made it pretty easy to build this on top. Jan
signature.asc
Description: OpenPGP digital signature
