22.08.2014 12:52, Valentin Manea wrote:
> Set the IDE MMIO memory type to little endian. The ATA specs identify
> words part of the control commands encoded as little endian.
> While this has no impact on little endian systems, it's required for big
> endian systems(eg OpenRisc).
While the patch itself is simple, I'm not sure it is "trivial enough".
And you didn't Cc neither qemu-devel@ nor the IDE subsystem "odd fixer"
maintainers (kwolf@ and stefanha@). I'm not applying this for now to
trivial tree.
Thanks,
/mjt
> Signed-off-by: Valentin Manea <valentin.ma...@gmail.com>
> ---
> hw/ide/mmio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ide/mmio.c b/hw/ide/mmio.c
> index 01c1d0e..334c8cc 100644
> --- a/hw/ide/mmio.c
> +++ b/hw/ide/mmio.c
> @@ -82,7 +82,7 @@ static void mmio_ide_write(void *opaque, hwaddr addr,
> static const MemoryRegionOps mmio_ide_ops = {
> .read = mmio_ide_read,
> .write = mmio_ide_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static uint64_t mmio_ide_status_read(void *opaque, hwaddr addr,
> @@ -102,7 +102,7 @@ static void mmio_ide_cmd_write(void *opaque, hwaddr
> addr,
> static const MemoryRegionOps mmio_ide_cs_ops = {
> .read = mmio_ide_status_read,
> .write = mmio_ide_cmd_write,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
> };
>
> static const VMStateDescription vmstate_ide_mmio = {
>
