Re: [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

[Vladimir Sementsov-Ogievskiy]

+    if (!name || name[0] == '\0') {
Isn't is better to move "name[0] == '\0'" check to 
bdrv_create_dirty_bitmap, near existed name checking?

+        if (granularity < 512 || is_power_of_2(granularity)) {
+            error_setg(errp, "Granularity must be power of 2 "
+                             "and greater than 512");
+            return;
+        }
+    } else {
+        granularity = 65536;
+    }
Why not using something like DEFAULT_CLUSTER_SIZE, as in block/qcow2.h ?

--
Best regards,
Vladimir