On 11/20/14 04:13, Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 09:11:41PM -0700, Eric Blake wrote:
On 11/19/2014 05:38 PM, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the value "auto" to do
the old way.
+++ b/qapi-schema.json
@@ -3513,3 +3513,19 @@
# Since: 2.1
##
{ 'command': 'rtc-reset-reinjection' }
+
+##
+# @vmport
+#
+# An enumeration of the options on enabling of VMWare ioport emulation
+#
+# @auto: system selects the old default
+#
+# @on: provide the vmport device
+#
+# @off: do not provide the vmport device
+#
+# Since: 2.2
+##
+{ 'enum': 'vmport',
All other enums in .json files are named in StudlyCaps. Please name
this starting with a capital letter, and reserve all-lower-case names
for commands and built-in types.
Hi Eric,
The values here are not vmport-specific.
Do you think we should have a generic OnOffAuto type?
I am waiting for a a clear direction on how to go.
VMPortConfig, Tristate, and OnOffAuto are the 3 names
I am tracking.
-Don Slutz
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
