On 11/20/2014 01:44 AM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote: >> c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 >> >> or >> >> c/s b154537ad07598377ebf98252fb7d2aff127983b >> >> moved the testing of xen_enabled() from pc_init1() to >> pc_machine_initfn(). >> >> xen_enabled() does not return the correct value in >> pc_machine_initfn(). >> >> Changed vmport from a bool to an enum. Added the value "auto" to do >> the old way. >> >> Signed-off-by: Don Slutz <dsl...@verizon.com> > > This looks fine to me. A couple of minor comments below. > Also this changes qapi schema file, let's get ack from maintainers - > my understanding is that just adding a definition there won't > affect any users, correct?
Correct; adding a definition won't break existing users, whether or not the new type is currently used by current commands. However, it's still worth designing the new enum type to be potentially reusable; the idea of naming it OnOffAuto makes sense to me. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
