>
> Out of curiosity, what are existing solutions?
>

Basically just attaching gdb and pulling memory out manually (or writing a
program to do the same).


> +struct request {
> > +    uint8_t type;      /* 0 quit, 1 read, 2 write, ... rest reserved */
> > +    uint64_t address;  /* address to read from OR write to */
> > +    uint64_t length;   /* number of bytes to read OR write */
> > +};
>
> Please add QEMU_PACKED to this structure, and probably name it
> QEMUMARequest,
> for name collision avoidance and CamelCase convension.
>

How critical is QEMU_PACKED?  This changes the layout of the struct which
means that existing clients (LibVMI) would need to change their code as
well.

-bryan

Reply via email to