On 15 December 2014 at 21:45, Greg Bellows <greg.bell...@linaro.org> wrote: > Should the has_el3 property errors on these machines also be silent (will > break -cpu host).
All the ones in this patch use the if (object_property_find(OBJECT(cpu), "has_el3", NULL)) { object_property_set_bool(OBJECT(cpu), false, "has_el3", &err); ... } pattern, which is fine, because -cpu host (and other non-EL3 CPUs like cortex-a57) will not have the property and we'll silently continue as we should. It's only the vexpress and virt boards where you made it fail on the property not existing. -- PMM