On 2015-01-29 at 04:36, Markus Armbruster wrote:
When find_block_job() fails, all its callers build the same Error
object.  Build it in find_block_job() instead.

Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
---
  blockdev.c | 19 ++++++++-----------
  1 file changed, 8 insertions(+), 11 deletions(-)

I think I'd like it better to return "Device not found" in case bdrv_find() fails, but that's probably a matter of taste:

Reviewed-by: Max Reitz <[email protected]>

Reply via email to