Max Reitz <mre...@redhat.com> writes: > On 2015-01-29 at 04:36, Markus Armbruster wrote: >> When find_block_job() fails, all its callers build the same Error >> object. Build it in find_block_job() instead. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> >> --- >> blockdev.c | 19 ++++++++----------- >> 1 file changed, 8 insertions(+), 11 deletions(-) > > I think I'd like it better to return "Device not found" in case > bdrv_find() fails, but that's probably a matter of taste:
Could be done on top. This patch intentionally doesn't change behavior. Of course, the whole job thing needs a redesign to liberate it from its tie to a single BDS. And then we won't bdrv_find() to find jobs. > Reviewed-by: Max Reitz <mre...@redhat.com> Thanks!
