On Thu, Feb 26, 2015 at 09:11:14PM -0600, Michael Roth wrote: > This enables hotplug of PCI devices to a PHB. Upon hotplug we > generate the OF-nodes required by PAPR specification and > IEEE 1275-1994 "PCI Bus Binding to Open Firmware" for the > device. > > We associate the corresponding FDT for these nodes with the DRC > corresponding to the slot, which will be fetched via > ibm,configure-connector RTAS calls by the guest as described by PAPR > specification. > > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com>
Apart from one nit,
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
[snip]
> +typedef struct ResourceFields {
> + uint32_t phys_hi;
> + uint32_t phys_mid;
> + uint32_t phys_lo;
> + uint32_t size_hi;
> + uint32_t size_lo;
> +} __attribute__ ((packed)) ResourceFields;
Should be QEMU_PACKED, rather than open-coding the gcc extension.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpCTGamyAzmz.pgp
Description: PGP signature
