(I forgot to Cc Eric in this series, doing it now) On Thu, Mar 19, 2015 at 03:42:35PM -0400, Max Reitz wrote: > > # Emitted when a corruption has been detected in a disk image > > # > >-# @device: device name > >+# @device: device name, or node name if not present > > Normally, if a field in QMP is designed @device, it contains a > device name. We do have combined device/node name fields, though (as > of John's incremental backup series, at least), but those are named > @node (which I proposed for patch 2, too). > > But renaming the field here will lead to breaking backwards > compatibility. I think just adding a @node-name field and keeping > @device as it is should be good enough here.
I was doing the same that we discussed for BlockJobInfo here, where option b) seemed to have a bit more support: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg03651.html But yeah I personally don't mind extending the event with a new field. Would we make 'device' optional in this case? Berto
