On 8 April 2015 at 11:51, Paolo Bonzini <pbonz...@redhat.com> wrote: > This could be the occasion to drop io_mem_read/io_mem_write and use > memory_region_dispatch_read/memory_region_dispatch_write altogether. As > you prefer.
Makes sense, I guess; memory_region_* are better named for what they do, so promoting those to non-static and dropping the wrappers seems a good move. Incidentally in the course of this patch I noticed that we have exactly two places outside the memory system that use these functions: hw/s390x/s390-pci-inst.c and hw/vfio/pci.c. Is this a reasonable thing, or should they in an ideal world have created an AddressSpace to access things through? (I have no opinion except that functions used in only one or two places always look a little suspicious to me :-)) -- PMM
