On Tue, Apr 07, 2015 at 09:10:00PM +0100, Peter Maydell wrote: > Fix a TODO in bp_wp_matches() now that we have a function for > testing whether the CPU is currently in Secure mode or not. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > --- > target-arm/op_helper.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index ce09ab3..d8a1054 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c > @@ -600,8 +600,10 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_wp) > CPUARMState *env = &cpu->env; > uint64_t cr; > int pac, hmc, ssc, wt, lbn; > - /* TODO: check against CPU security state when we implement TrustZone */ > - bool is_secure = false; > + /* Note that for watchpoints the check is against the CPU security > + * state, not the S/NS attribute on the offending data access. > + */ > + bool is_secure = arm_is_secure(env); > int access_el = arm_current_el(env); > > if (is_wp) { > -- > 1.9.1 >