On 8 April 2015 at 12:04, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 07/04/2015 22:09, Peter Maydell wrote: >> Capture the memory attributes for the transaction which triggered >> a watchpoint; this allows CPU specific code to implement features >> like ARM's "user-mode only WPs also hit for LDRT/STRT accesses >> made from privileged code". >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > Oops, here we are. :) > > If you want to move the patch early, and possibly convert > watch_mem_read/write to use a buffer in the style of subpages, that > would be great.
Yeah, you got me -- I forgot about watchpoints and then didn't want to wrestle with moving this patch before the big coccinelle patch... Just laziness, so I'll shift it. -- PMM