On Thu, 23 Apr 2015 14:26:44 +0200 Christian Borntraeger <borntrae...@de.ibm.com> wrote:
> Am 09.04.2015 um 10:51 schrieb Cornelia Huck: > > From: Thomas Huth <th...@linux.vnet.ibm.com> > > > > The "switch_amode" parameter has been removed from the Linux kernel > > sources since version 3.7 - so QEMU should not advise this parameter > > nowadays anymore. > > > > Signed-off-by: Thomas Huth <th...@linux.vnet.ibm.com> > > Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> > > Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com> > > --- > > kvm-all.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/kvm-all.c b/kvm-all.c > > index dd44f8c..7c8537b 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -1542,11 +1542,6 @@ static int kvm_init(MachineState *ms) > > if (ret < 0) { > > fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret, > > strerror(-ret)); > > - > > -#ifdef TARGET_S390X > > - fprintf(stderr, "Please add the 'switch_amode' kernel parameter to > > " > > - "your host kernel command line\n"); > > -#endif > > goto err; > > } > > > > Can you drop this patch from your upcoming pull request? > > See the discussion on http://marc.info/?l=kvm&m=142978728714865&w=2 > We might want to change the error message instead of getting rid of it. Can do, although I think what we want in the end is something different from the current message anyway.