On 05/05/2015 07:22 PM, Eric Blake wrote: > On 05/05/2015 04:22 PM, John Snow wrote: >> qtest currently has a static buffer of size 1024 that if we >> overflow, ignores the additional data silently which leads to >> hangs or stream failures. >> >> Use glib's string facilities to allow arbitrarily long data, but >> split this off into a new function, qtest_sendf. >> >> Static data can still be sent using qtest_send, which avoids the >> malloc/copy overflow. > > Did you mean 'overhead' instead of 'overflow'? >
Sigh, yes. The fingers run on autopilot without input from the brain. Will nab it if I spin again. >> >> Signed-off-by: John Snow <js...@redhat.com> --- qtest.c | 46 >> ++++++++++++++++++++++++++++------------------ 1 file changed, 28 >> insertions(+), 18 deletions(-) >> > >> qtest_send_prefix(chr); - qtest_send(chr, "FAIL Unknown >> command `%s'\n", words[0]); + qtest_sendf(chr, "FAIL >> Unknown command `%s'\n", words[0]); } > > Unrelated - these days, I don't see `this' quoting much any more > (except in m4); most people have moved to 'this' quoting. We could > clean it while touching this line, but it really doesn't affect > correctness either way. > If I spin again I'll get it. > Reviewed-by: Eric Blake <ebl...@redhat.com> >
