On 06.05.15 15:46, Fam Zheng wrote: > Because of the trick of process-archive-undefs, all .mo objects, even > with --enable-modules, are dependencies of executables. > > This breaks CFLAGS propogation because the compiling of module object > will happen too early before building for DSO. > > With GCC 5, the linking would fail because .o doesn't have -fPIC. Also, > BUILD_DSO will be missed. (module-common.o will have it, so the stamp > symbol was still liked in .so). > > Fix the problem by forcing the CFLAGS during unnest-vars. > > Reported-by: Alexander Graf <ag...@suse.de> > Signed-off-by: Fam Zheng <f...@redhat.com>
As a heads-up I just verified that this patch does indeed fix compilation with gcc5 for me. However looking at the mail thread I assume there's a v2 coming, so I'll hold off my tested-by tag ;). For the final patch, we will probably also want to have it in the qemu-stable tree, so that people will be able to compile older versions of qemu (and modules) with newer compilers. Alex
