Michael Tokarev <m...@tls.msk.ru> writes: > In this version I used mkdtemp(3) which is: > > _BSD_SOURCE > || /* Since glibc 2.10: */ > (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700) > > (POSIX.1-2008), so should be available on systems we care about. > > While at it, reset the resulting directory name within smb structure > on error so cleanup function wont try to remove directory which we > failed to create. > > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> > --- > v2: > Add resetting of the dirname on failure so that cleanup function > does not try to remove directory which we failed to create. > > Use snprintf() as was in the original code, not strcpy(): while > in this very case it does not matter at all since both strings > are of known size, some people dislike strcpy() in principle.
I guess I would've used pstrcpy(), but your use of snprintf() is just fine. Reviewed-by: Markus Armbruster <arm...@redhat.com>
