> On May 6, 2015, at 5:14 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > > On 06/05/2015 13:57, Yossi Hindin wrote: >> The second version of commits's set take into account Paolo Bonzini remarks. >> >> Typo in WXS file fixed, QEMU GA-related CLI options renamed, >> '--enable-guest-agent-msi'/ >> '--disable-guest-agent-msi' processing logic changed so that MSI build is >> configured >> by default, unless some prerequisite is missing and MinGW DLL path variable >> is computed >> together with all QEMU GA MSI variables. >> >> Also, I've slightly changed Makefile structure so that if MSI build was not >> configured, >> Makefile prints suitable message. >> >> >> Yossi Hindin (4): >> qemu-ga: adding vss-[un]install options >> qemu-ga: debug printouts to help troubleshoot installation >> qemu-ga: Introduce Windows MSI script >> qemu-ga: Building Windows MSI installation with configure/Makefile >> >> Makefile | 24 +++++++- >> configure | 66 +++++++++++++++++++++ >> qga/channel-win32.c | 2 +- >> qga/commands-win32.c | 1 + >> qga/installer/qemu-ga.wxs | 145 >> ++++++++++++++++++++++++++++++++++++++++++++++ >> qga/main.c | 10 +++- >> 6 files changed, 245 insertions(+), 3 deletions(-) >> create mode 100644 qga/installer/qemu-ga.wxs >> > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > >
Ping.
