On Tue, 16 Jun 2015 15:08:41 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes: > > > On Sat, 13 Jun 2015 16:20:47 +0200 > > Markus Armbruster <arm...@redhat.com> wrote: > > > >> After a bit over a year and many patches, QError is finally ripe. All > >> that's left of qerror.h after this series is a bunch of QERR_ macros. > >> Killing them is left for another day. > > > > Excellent! > > > > I did my best to review this series, but unfortunately my review is > > a bit weak because I'm not that familiar with some code paths > > (like QemuOpts) and I was unable to apply patches starting with patch 04/11. > > Did you apply on top of my "[PATCH v2 0/7] qdev: Mostly wean off > QError"? No, I assumed it was already merged. > > But it does look good to me: > > > > Reviewed-by: Luiz Capitulino <lcapitul...@redhat.com> > > Thanks! >