On Thu, Sep 10, 2015 at 11:28:03AM +0200, Paolo Bonzini wrote: > > > On 10/09/2015 11:25, Michael S. Tsirkin wrote: > > > It is needed because kvm headers include <asm/hyperv.h> and you don't > > > want to pick the system version. > > > > I see. Makes sense. Then maybe don't bother with kvm.c either? > > Keeps it consistent ... > > kvm.c keeps it consistent between target-i386/kvm.c and > target-i386/cpu.h (which will include standard-headers/asm-x86/hyperv.h > in Denis's patch). > > Paolo
Yes but kvm_para.h uses asm/hyperv.h MAybe do the same everywhere? Seems marginally prettier, but you decide, I'm not interested in pushing this point. -- MST
