On 09/15/2015 08:06 PM, Yuanhan Liu wrote: >> Up to here is mostly fine for the commit message. Meanwhile... >> >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handlers() >>> once only, and invoke qemu_find_net_clients_except() at the handler >>> to gather all related ncs, for initiating all queues. Which addresses >>> a hidden bug in older verion in a more QEMU-like way. >>> >>> v8: set net->dev.vq_index correctly inside vhost_net_init() based on the >>> value from net->nc->queue_index. >> >> ...this chunk here is useful only on the mailing list, and not in git, >> and therefore, should appear... > > Sorry that I may disagree here. > > First of all, it does no harm at all to include few old version > descriptions. Instead, it may give some hints to the reader how > the patch evolves. Meanwhile, you will find they are quite common > in some well known open source projects, such as linux kernel:
There's nothing wrong with including patch changelog in your mail; in fact it is encouraged by: http://wiki.qemu.org/Contribute/SubmitAPatch However, we DO request that you put it after ---, because we do NOT want it in qemu.git log. I don't care if the kernel has a slightly different policy, and is more tolerant of changelogs leaked into the git log. > You can find them at qemu project (though not that common), too: > > [yliu@yliu-dev ~/qemu]$ git log | grep '\<[vV][1-9][0-9]*:' | wc -l > 390 They're not common for a reason - we've documented that we don't like them in git. And that's because we expect the --- separator between the git message and the changelog. > > So, if it's a qemu community specific culture, I could do what > you suggested. Yes, since it is documented at http://wiki.qemu.org/Contribute/SubmitAPatch, it is qemu culture. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
