On 09/18/2015 09:22 AM, Max Reitz wrote: > In order to handle host device passthrough, some guest device models > may call blk_is_inserted() to check whether the medium is inserted on > the host, when checking the guest tray status. > > This tray status is inquired by blk_dev_change_media_cb(); because > bdrv_is_inserted() (invoked by blk_is_inserted()) always returns 0 for
Stale comment - you just fixed bdrv_is_inserted() to return false rather than 0 in commit 5/38. > BDS with drv set to NULL, blk_dev_change_media_cb() should therefore be > called before drv is set to NULL. > > Signed-off-by: Max Reitz <mre...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > --- > block.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) R-b still stands. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
