On 18/09/2015 15:18, Daniel P. Berrange wrote: > David Gilbert had some feedback on my previous RFC series which > I have incorporated into this new posting. I did forget his > comments about using #defines instead of magic constants in > the websock patch, so that's still on my todo list. > > Finally I've listed myself as maintainer for the new io/ and > include/io/ directory prefixes.
I only made a few very small remarks. The API is reasonable and you've proved its utility by using it in the rest of your project. I remember I had some remarks about the rest of the conversion and especially the integration with coroutines, but it's not part of this series. Paolo
