On 10/18/15 19:35, Andrew Jones wrote: > Changes from v1 > . drop the RFC patch "arm_gic_common.h: add gicv2 aliases for defines" [Peter] > . add a patch to cleanup vl.c's max-cpu error message a little [Drew] > . cleanup mach-virt's new error message [Peter] > . make the error message exactly like vl's cleaned up message [Drew] > . add a comment to virt_class_init explaining that we'll further restrict > max_cpus later [Peter] > > --- > > Sorry to be so late getting this simple v2 out. I was trying to > get a new feature (qmp-dump-guest-memory support for arm) posted > before the 2.5 soft freeze (but missed that anyway...)
(off-topic) When you do that, please consider extending the "scripts/dump-guest-memory.py" script as well. (This is not even a "nice to have" request -- the script already doesn't support all the target arches on which the QMP command is available (it only supports x86_64), so nothing is lost if you don't extend the script. My only goal is to put the thought in your mind; you decide :)) Thanks! Laszlo > > Andrew Jones (2): > vl: trivial: minor tweaks to a max-cpu error msg > hw/arm/virt: don't use a15memmap directly > > hw/arm/virt.c | 25 +++++++++++++++++++++---- > vl.c | 4 ++-- > 2 files changed, 23 insertions(+), 6 deletions(-) >
