On 10/26/2015 11:54 AM, Markus Armbruster wrote: >> It sounds like I have two options for v11: >> >> 1. Keep 9/25 introducing gen_upcast(), just for union types, and >> including testsuite coverage. In 10/25, make use of the upcast functions >> to struct as part of making structs sane. >> >> 2. Swap the patch order: do 10/25 to alter struct layout first, using >> ugly casts; then implement 9/25 that adds gen_upcast() and fixes the >> ugly casts to instead use the new upcast functions. >> >> I can go either way, so do you have any preference? > > I think I'd 3. Do 10/25 first, with gen_upcast() squashed in, and used > for casts to base. That gen_upcast() will just work for unions, too. > Least churn.
I actually started with option 3 back when first writing v10, then decided that it made the patch big enough, and the addition was orthogonal enough, to go with the split patches at the time I actually posted v10. > > But any of the three options should work. Good. Because I had already gone with option 1 locally before asking the question, which means now I don't have to respin to get option 2 or 3 :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
