On 05/28/10 16:21, Paul Brook wrote:
Try to pci hotplug a vga card, watch qemu die with hw_error().
This patch fixes it.
I think this is wrong. There's no reason why VGA adapters shouldn't be
hotplugged. You should fix the underlying problems that prevent hotplugging
The qemu code base simply isn't prepared for that. Making vga hotplug
requires alot of infrastructure work within qemu, see discussion with
Stefano in this thread. I'm also not fully sure it is possible to
hotplug the primary vga due to the legacy vga i/o ports.
(or make them fail gracefully).
Make hotplug fail gracefully is exactly what the patch does because
making hotplug work is impossible short-term IMHO.
cheers,
Gerd
