On 17 December 2015 at 13:45, Daniel P. Berrange <berra...@redhat.com> wrote: > The following changes since commit c1a5f950cdeeaea6a835b2b33f040a0e62c18662: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-12-17' > into staging (2015-12-17 11:50:46 +0000) > > are available in the git repository at: > > git://github.com/berrange/qemu tags/pull-io-channel-base-2015-12-17-1 > > for you to fetch changes up to 37c41c79730f7535c54f304e5c6e89fbf2cfe0e5: > > io: add QIOChannelBuffer class (2015-12-17 13:26:04 +0000) > > ---------------------------------------------------------------- > Merge I/O channels base classes > > ---------------------------------------------------------------- > Daniel P. Berrange (9): > io: add abstract QIOChannel classes > io: add helper module for creating watches on FDs > io: add QIOTask class for async operations > io: add QIOChannelSocket class > io: add QIOChannelFile class > io: add QIOChannelTLS class > io: add QIOChannelWebsock class > io: add QIOChannelCommand class > io: add QIOChannelBuffer class
Hi. I'm afraid this fails to build on OSX: In file included from /Users/pm215/src/qemu-for-merges/io/channel.c:21: /Users/pm215/src/qemu-for-merges/include/io/channel.h:127:5: error: type name requires a specifier or qualifier off64_t (*io_seek)(QIOChannel *ioc, ^ /Users/pm215/src/qemu-for-merges/include/io/channel.h:127:15: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] off64_t (*io_seek)(QIOChannel *ioc, ^ /Users/pm215/src/qemu-for-merges/include/io/channel.h:128:24: error: unknown type name 'off64_t'; did you mean 'off_t'? off64_t offset, ^~~~~~~ off_t /usr/include/sys/_types/_off_t.h:30:25: note: 'off_t' declared here typedef __darwin_off_t off_t; ^ In file included from /Users/pm215/src/qemu-for-merges/io/channel.c:21: /Users/pm215/src/qemu-for-merges/include/io/channel.h:127:13: error: function cannot return function type 'int (QIOChannel *, off_t, int, Error **)' off64_t (*io_seek)(QIOChannel *ioc, ^ /Users/pm215/src/qemu-for-merges/include/io/channel.h:421:1: error: unknown type name 'off64_t'; did you mean 'off_t'? off64_t qio_channel_io_seek(QIOChannel *ioc, ^~~~~~~ off_t /usr/include/sys/_types/_off_t.h:30:25: note: 'off_t' declared here typedef __darwin_off_t off_t; ^ In file included from /Users/pm215/src/qemu-for-merges/io/channel.c:21: /Users/pm215/src/qemu-for-merges/include/io/channel.h:422:29: error: unknown type name 'off64_t'; did you mean 'off_t'? off64_t offset, ^~~~~~~ off_t /usr/include/sys/_types/_off_t.h:30:25: note: 'off_t' declared here typedef __darwin_off_t off_t; ^ /Users/pm215/src/qemu-for-merges/io/channel.c:191:1: error: unknown type name 'off64_t'; did you mean 'off_t'? off64_t qio_channel_io_seek(QIOChannel *ioc, ^~~~~~~ off_t /usr/include/sys/_types/_off_t.h:30:25: note: 'off_t' declared here typedef __darwin_off_t off_t; ^ /Users/pm215/src/qemu-for-merges/io/channel.c:192:29: error: unknown type name 'off64_t'; did you mean 'off_t'? off64_t offset, ^~~~~~~ off_t /usr/include/sys/_types/_off_t.h:30:25: note: 'off_t' declared here typedef __darwin_off_t off_t; ^ /Users/pm215/src/qemu-for-merges/io/channel.c:198:17: error: no member named 'io_seek' in 'struct QIOChannelClass' if (!klass->io_seek) { ~~~~~ ^ /Users/pm215/src/qemu-for-merges/io/channel.c:203:19: error: no member named 'io_seek' in 'struct QIOChannelClass' return klass->io_seek(ioc, offset, whence, errp); ~~~~~ ^ 1 warning and 9 errors generated. thanks -- PMM