On 06/03/2010 07:31 AM, Paolo Bonzini wrote:
On 06/03/2010 10:56 AM, Gautham R Shenoy wrote:
Add qemu wrappers for pthread_attr_t handling.

The point of these wrappers AFAIU is not only to add error_exit, but also to be portable to Windows in the future. Is it necessary to create the threads as detached? If you set queue->min_threads to zero all threads should exit as soon as they finish their work (which is better than exiting immediately).

This is historical because the code was largely inspired by glibc's implementation of posix-aio. It doesn't need to be detached and since Corentin wants to be able to join a worker, it makes sense to just avoid detaching and pay the overhead of making the threads joinable.

Regards,

Anthony Liguori

Paolo



Reply via email to